infra: apply final portal spec updates and remove portal submodule#248
Open
marc0olo wants to merge 1 commit into
Open
infra: apply final portal spec updates and remove portal submodule#248marc0olo wants to merge 1 commit into
marc0olo wants to merge 1 commit into
Conversation
Apply three upstream spec changes from dfinity/portal@fe646b2 (the final commit before deprecation): - canister_metrics endpoint: new management canister query method that returns cycle consumption broken down by memory, compute, ingress, instructions, http outcalls, etc. Applied to ic.did, changelog (v0.61.0), management-canister.md (method doc + reference entry), and abstract-behavior.md (method-list, abstract rule, query call conditions). - sender_info validation refactor (dc29431): move sender_info checks into verify_envelope predicate; remove five now-redundant per-call blocks from update and query call conditions in abstract-behavior.md. - Ingress expiry typo fix (8304ab0): add missing "or RS.sender = anonymous_id" to the subnet read-state ingress_expiry condition. Remove the dfinity/portal git submodule (.sources/portal). The spec files it synced — ic.did, certificates.cddl, requests.cddl, http-gateway.did, the ic-interface-spec split pages, and http-gateway-spec.md — are now maintained directly in this repository. Update AGENTS.md: remove portal from the submodule table and per-submodule bump checklist; replace the "Synced files from submodules" / "Portal bump checklist" sections with a "Directly maintained spec files" table; remove the "Portal tracking" section. Update README.md, .sources/VERSIONS, and .docs-plan/content-authoring.md to remove remaining operational portal references.
github-actions
Bot
added
the
interface-spec
|
🤖 Here's your preview: https://soxyi-6iaaa-aaaam-ai2ra-cai.icp0.io |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dfinity/portal@fe646b2(the final commit we sync before removing the submodule):canister_metricsendpoint (fe646b2): new management canister query method returning cycle consumption broken down by memory, compute, ingress induction, instructions, HTTP outcalls, etc. Ported toic.did,changelog.md(v0.61.0),management-canister.md(spec page + reference page entry), andabstract-behavior.md(allowed-methods list, abstract rule, query call conditions).sender_infovalidation refactor (dc29431): sender_info checks consolidated intoverify_envelopepredicate; five now-redundant per-call blocks removed from update and query call conditions inabstract-behavior.md.8304ab0): added missingor RS.sender = anonymous_idto the subnet read-stateingress_expirycondition inabstract-behavior.md.dfinity/portalgit submodule (.sources/portal). The spec files it synced —ic.did,certificates.cddl,requests.cddl,http-gateway.did, theic-interface-spec/split pages, andhttp-gateway-spec.md— are now maintained directly in this repository.AGENTS.md: removed portal from the submodule table and per-submodule bump checklist; replaced the "Synced files from submodules" / "Portal bump checklist" block with a leaner "Directly maintained spec files" table; removed the "Portal tracking" section.README.md,.sources/VERSIONS,.docs-plan/content-authoring.mdto remove remaining operational portal references.Sync recommendation
hand-written— spec content is now maintained directly in this repository; no upstream submodule to sync from.